Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test white background for plots in dark mode #2730

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Test white background for plots in dark mode #2730

wants to merge 3 commits into from

Conversation

jayhesselberth
Copy link
Collaborator

Closes #2729

@jayhesselberth jayhesselberth mentioned this pull request Jul 24, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 24, 2024 •
edited
Loading

🚀 Deployed on https://66a1407f56955010de4e0180--pkgdown-dev.netlify.app

@jayhesselberth jayhesselberth changed the title Use white background for plots in dark mode Test white background for plots in dark mode Jul 24, 2024
@hadley
Copy link
Member

hadley commented Jul 25, 2024

Hmmmm, is this a vignette specific problem? I re-looked at the scss and discovered that I added this for plots in examples:

pre .img, pre .r-plt {
  img {
    margin: 5px 0;
    background-color: #fff;
  }
}
// low-tech plot softening in dark mode
[data-bs-theme="dark"] pre img {
  opacity: 0.66;
  transition: opacity 250ms ease-in-out;

  &:hover, &:focus, &:active {opacity: 1;}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot() outputs require white background (or white lines?) for the dark mode website
2 participants
@jayhesselberth @hadley